Fix Web Handlers not executing with Re-ask option #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #519, I implemented initial support for Web Handlers, which extend ChatCraft's URL handling capabilities.
However, @tarasglek noticed that when a non-matching prompt is edited to a valid url pattern that is configured in Web Handlers configuration, prompt is still sent to LLM instead of invoking the corresponding Web Handler.
I researched a bit and found that the reason for this to happen was that the
Resubmit
handler function for the message form was not passing the prompt text to theonPrompt
function.This is why the handler wasn't able to determine any specifics about the prompt. I am now passing the text to that handler so
onPrompt
inChatBase
knows that it needs to be passed to a Web Handler.Before:
After:
This fixes #541