Add loading indicator for the image compression #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
2597843
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c1dc76b.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://mingming-loadingindicator-46.console-overthinker-dev.pages.dev |
WangGithub0
reviewed
Mar 7, 2024
| .then((base64Strings) => { | ||
| setInputImageUrls((prevImageUrls) => [...prevImageUrls, ...base64Strings]); | ||
| }) | ||
| .catch((err) => { |
There was a problem hiding this comment.
do you still need add the catch err in your processImages function?
There was a problem hiding this comment.
Yeah, the processImages function has catch for handling errors, do you mean we can remove it?
There was a problem hiding this comment.
Keep it please. We don't want to fail and crash, or fail silently.
There was a problem hiding this comment.
Yeah, the processImages function has catch for handling errors, do you mean we can remove it?
sorry, github folded that part, I thought you miss it.
It looks good to me!
WangGithub0
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
I set the
imageUrlto empty string firstly inside the process image functions and then update it with real url result when compression is done. If it is empty, thespinnerin a square box will be rendered as loading status.Result
Fixes: #467