-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: solves display bug of category chevron buttons #629
fix: solves display bug of category chevron buttons #629
Conversation
Someone is attempting to deploy a commit to the Lenstube Team on Vercel. A member of the Team first needs to authorize it. |
✅ Deploy Preview for lenstube-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lenstube ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@abhiram11 We can rename typo in the file name to correct spelling 👍🏻 |
…hub.com/abhiram11/lenstube into abhiram11/bug-solve-ui-category-chevron
I have pushed a new commit with the following updates:
P.S. I am new to open source contribution and git, so if there are any issues with my PR or git calls, please provide feedback for the same! |
You did all great. Thank you for your contribution. 😊 |
Thank you for the feedback! ^^ Feel free to let me know if there are any other issues that I can help with, especially in Javascript, Python, and Frontend. Have a great weekend! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can always pick from issues or suggest feature requests (roadmap.lenstube.xyz) |
Congrats, your important contribution to this open-source project has earned you a GitPOAP! GitPOAP: 2023 Lenstube Contributor: Head to gitpoap.io & connect your GitHub account to mint! Learn more about GitPOAPs here. |
@abhiram11 ☝🏻 |
This is great! Thanks for the recognition!! 😊 |
Description
Closes #628
Type of change
Checklist
Note: Kindly check the Bug Report #628 where I have elaborated on the issue in more detail.
This PR solves the display bug where the
<
and>
category buttons require an extra event to be called/clicked in order to render on the page as required by the logic.This is how the proposed solution in my PR looks like:
The URL shows the difference between the current behavior (lenstube) and the expected behavior (localhost)
2023-02-18.02-57-54.mp4
P.S. I am new to open-source contributions, I am all ears to feedback! Furthermore, we can also refactor the filename
utils/hooks/useHorizantalScroll
and correct the spelling toHorizontal
. ^^