Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: solves display bug of category chevron buttons #629

Merged

Conversation

abhiram11
Copy link
Contributor

Description

Closes #628

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

Note: Kindly check the Bug Report #628 where I have elaborated on the issue in more detail.

This PR solves the display bug where the < and > category buttons require an extra event to be called/clicked in order to render on the page as required by the logic.

This is how the proposed solution in my PR looks like:

The URL shows the difference between the current behavior (lenstube) and the expected behavior (localhost)

2023-02-18.02-57-54.mp4

P.S. I am new to open-source contributions, I am all ears to feedback! Furthermore, we can also refactor the filename utils/hooks/useHorizantalScroll and correct the spelling to Horizontal. ^^

@abhiram11 abhiram11 requested a review from sasicodes as a code owner February 17, 2023 22:10
@vercel
Copy link

vercel bot commented Feb 17, 2023

Someone is attempting to deploy a commit to the Lenstube Team on Vercel.

A member of the Team first needs to authorize it.

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for lenstube-embed ready!

Name Link
🔨 Latest commit f15beda
🔍 Latest deploy log https://app.netlify.com/sites/lenstube-embed/deploys/63f088763283bd000862daae
😎 Deploy Preview https://deploy-preview-629--lenstube-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 17, 2023

Deploy Preview for lenstube ready!

Name Link
🔨 Latest commit f15beda
🔍 Latest deploy log https://app.netlify.com/sites/lenstube/deploys/63f088766cfa290008068349
😎 Deploy Preview https://deploy-preview-629--lenstube.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sasicodes sasicodes changed the title solves display bug of category chevron buttons fix: solves display bug of category chevron buttons Feb 18, 2023
@vercel
Copy link

vercel bot commented Feb 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
api ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 18, 2023 at 8:23AM (UTC)

@sasicodes
Copy link
Member

sasicodes commented Feb 18, 2023

@abhiram11 We can rename typo in the file name to correct spelling 👍🏻

@abhiram11
Copy link
Contributor Author

I have pushed a new commit with the following updates:

  1. Changed let to const
  2. Removed Comments
  3. Updated filename to useHorizontalScroll and modified wherever it is called.

P.S. I am new to open source contribution and git, so if there are any issues with my PR or git calls, please provide feedback for the same!

@sasicodes
Copy link
Member

I have pushed a new commit with the following updates:

  1. Changed let to const
  2. Removed Comments
  3. Updated filename to useHorizontalScroll and modified wherever it is called.

P.S. I am new to open source contribution and git, so if there are any issues with my PR or git calls, please provide feedback for the same!

You did all great. Thank you for your contribution. 😊

@abhiram11
Copy link
Contributor Author

Thank you for the feedback! ^^ Feel free to let me know if there are any other issues that I can help with, especially in Javascript, Python, and Frontend.

Have a great weekend!

Copy link
Member

@sasicodes sasicodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dog LGTM Keyboard

@sasicodes
Copy link
Member

You can always pick from issues or suggest feature requests (roadmap.lenstube.xyz)

@sasicodes sasicodes merged commit a59d129 into tapexyz:main Feb 18, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Feb 18, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Lenstube Contributor:

GitPOAP: 2023 Lenstube Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@sasicodes
Copy link
Member

@abhiram11 ☝🏻

@abhiram11
Copy link
Contributor Author

This is great! Thanks for the recognition!! 😊

@abhiram11 abhiram11 deleted the abhiram11/bug-solve-ui-category-chevron branch February 19, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug (with solution PR): Video Category's Chevron Icons update late based on click event
2 participants