Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage)/get-signed-url-unclosed-session #838

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(storage)/get-signed-url-unclosed-session #838

wants to merge 1 commit into from

Conversation

korabs-x
Copy link

@korabs-x korabs-x commented Dec 8, 2024

Summary

Issue: When using blob.get_signed_url without passing a session or iam_client, a new session will be opened but never closed.

Summary of changes: Check if the user provided a session either through session or implicitly through iam_client, and if not close the iam_client after the operation.

@korabs-x korabs-x requested review from TheKevJames, cphoward and a team as code owners December 8, 2024 08:01
@korabs-x korabs-x requested review from mauroparis and removed request for a team December 8, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheKevJames TheKevJames Awaiting requested review from TheKevJames TheKevJames is a code owner

@cphoward cphoward Awaiting requested review from cphoward cphoward is a code owner

@mauroparis mauroparis Awaiting requested review from mauroparis mauroparis is a code owner automatically assigned from talkiq/engineering

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@korabs-x