New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest-auth): resp.text() for aiohttp but resp.text for requests lib #695

Merged

leanaha merged 1 commit into master from leanaha/fix-rest-get-iap-token

Mar 13, 2024

Contributor

leanaha commented Mar 13, 2024 •

edited

Loading

Summary

Since this lib uses aiohttp for aio calls and requests for rest calls, we need to suppport both usages.

For getting iap token I use the same solution as in lines 200-203.


          fix(rest-auth): resp.text() for aiohttp but resp.text for requests lib

6dc9cd7

leanaha requested review from TheKevJames and a team as code owners

March 13, 2024 16:37

leanaha requested review from shaundialpad and aherrada-dialpad and removed request for a team

March 13, 2024 16:37

juanamari94 approved these changes

View reviewed changes

leanaha merged commit 1110d8e into master

86 checks passed

leanaha deleted the leanaha/fix-rest-get-iap-token branch

March 13, 2024 16:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

juanamari94 juanamari94 approved these changes

TheKevJames Awaiting requested review from TheKevJames TheKevJames is a code owner

shaundialpad Awaiting requested review from shaundialpad shaundialpad is a code owner automatically assigned from talkiq/engineering

aherrada-dialpad Awaiting requested review from aherrada-dialpad aherrada-dialpad is a code owner automatically assigned from talkiq/engineering

Labels

None yet