Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): fixup support for aiohttp >= 3.9.3 #689

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix(deps): fixup support for aiohttp >= 3.9.3 #689

merged 1 commit into from
Mar 12, 2024

Conversation

TheKevJames
Copy link
Member

Summary

Ensure timeouts are properly coerced in all AioSession methods.

@TheKevJames TheKevJames requested review from shaundialpad and a team as code owners March 8, 2024 14:03
@TheKevJames TheKevJames requested review from juanamari94 and sknadig-dialpad and removed request for a team March 8, 2024 14:03
@TheKevJames TheKevJames mentioned this pull request Mar 8, 2024
Open
1 task
juanamari94
juanamari94 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@juanamari94 juanamari94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

eddiedialpad
eddiedialpad approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@eddiedialpad eddiedialpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved: aiohttp timeout enforcement change requiring type coercion;

@TheKevJames TheKevJames force-pushed the kjames/support-aiohttp-3.9.3 branch from 580dd6d to 0506a17 Compare March 12, 2024 10:45
@TheKevJames TheKevJames enabled auto-merge (squash) March 12, 2024 10:45
@TheKevJames TheKevJames merged commit d20d2f3 into master Mar 12, 2024
84 of 85 checks passed
@TheKevJames TheKevJames deleted the kjames/support-aiohttp-3.9.3 branch March 12, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiedialpad eddiedialpad eddiedialpad approved these changes

@juanamari94 juanamari94 juanamari94 approved these changes

@shaundialpad shaundialpad Awaiting requested review from shaundialpad

@sknadig-dialpad sknadig-dialpad Awaiting requested review from sknadig-dialpad sknadig-dialpad is a code owner automatically assigned from talkiq/engineering

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheKevJames @juanamari94 @eddiedialpad