Update default drop-shadow-* values to use a single shadow
#15056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think we need to do the same in here:
Otherwise this won't work. Let's add drop-shadow to the list of tests.
diff --git a/packages/tailwindcss/src/utilities.test.ts b/packages/tailwindcss/src/utilities.test.ts
index b16c6f125..e6120023c 100644
--- a/packages/tailwindcss/src/utilities.test.ts
+++ b/packages/tailwindcss/src/utilities.test.ts
@@ -13639,6 +13639,7 @@ test('filter', async () => {
'invert',
'invert-0',
'invert-[var(--value)]',
+ 'drop-shadow',
'drop-shadow-xl',
'drop-shadow-[0_0_red]',
'saturate-0',
@@ -13692,6 +13693,11 @@ test('filter', async () => {
filter: var(--tw-blur, ) var(--tw-brightness, ) var(--tw-contrast, ) var(--tw-grayscale, ) var(--tw-hue-rotate, ) var(--tw-invert, ) var(--tw-saturate, ) var(--tw-sepia, ) var(--tw-drop-shadow, );
}
+ .drop-shadow {
+ --tw-drop-shadow: drop-shadow(var(--drop-shadow));
+ filter: var(--tw-blur, ) var(--tw-brightness, ) var(--tw-contrast, ) var(--tw-grayscale, ) var(--tw-hue-rotate, ) var(--tw-invert, ) var(--tw-saturate, ) var(--tw-sepia, ) var(--tw-drop-shadow, );
+ }
+
.drop-shadow-\\[0_0_red\\] {
--tw-drop-shadow: drop-shadow(0 0 red);
filter: var(--tw-blur, ) var(--tw-brightness, ) var(--tw-contrast, ) var(--tw-grayscale, ) var(--tw-hue-rotate, ) var(--tw-invert, ) var(--tw-saturate, ) var(--tw-sepia, ) var(--tw-drop-shadow, );
|
Can't add a suggestion/comment on untouched lines so had to do it this way 😅 |
We updated the drop shadow values to have a single shadow instead of multiple values which allows us to keep using the `var(…)` instead of inlining it. The caveat is that if you define a custom drop shadow that contains multiple values then that won't be valid CSS because the two (or more) drop shadows will be wrapped in a `drop-shadow(shadow-1, shadow-2, …)`
philipp-spiess
approved these changes
Nov 21, 2024
thecrypticace
changed the title
drop-shadowdrop-shadow-* values to use a single shadow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default
drop-shadow-*values to use a single shadow instead of multiple shadows.This ensures that the usage with
drop-shadow(var(--drop-shadow-xl))is correct because thedrop-shadow(…)needs to encode a single drop shadow.