Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compat for <alpha-value> from v3 #15033

Merged
merged 5 commits into from
Nov 19, 2024

Conversation

thecrypticace
Copy link
Contributor

This implements backwards compatibility for colors that use the old <alpha-value> feature from v3. We can do this by replacing <alpha-value> with 1 because we use color-mix to actually apply opacity modifiers in v4.

@thecrypticace thecrypticace marked this pull request as ready for review November 18, 2024 20:09
@thecrypticace thecrypticace requested a review from a team as a code owner November 18, 2024 20:09
@thecrypticace thecrypticace force-pushed the feat/v4-alpha-value-compat branch from fa9cee7 to d534fcd Compare November 18, 2024 20:12
Copy link
Member

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff

@thecrypticace thecrypticace merged commit b73c746 into next Nov 19, 2024
1 check passed
@thecrypticace thecrypticace deleted the feat/v4-alpha-value-compat branch November 19, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants