Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make leading-none a static utility #14934

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Conversation

adamwathan
Copy link
Member

This PR removes the --leading-none variable from the default theme in favor of making leading-none a static utility, since it doesn't make sense to change the value of this on a per-project basis. This is consistent with how none values work for other utilities in the framework.

Some folks in the past have wanted leading-none to be line-height: 0 but technically "leading" is the space between lines, and line-height: 1 removes all extra space between lines so it feels correct to me (although it means all of the numeric utilities like leading-6 are not technically correct but I try hard not to think about that too much).

If someone wants line-height: 0 they can use leading-0 in v4 since the leading-* utilities inherit the spacing scale now.

@adamwathan adamwathan requested a review from a team as a code owner November 9, 2024 14:31
@adamwathan adamwathan merged commit 4f76980 into next Nov 9, 2024
1 check passed
@adamwathan adamwathan deleted the change/make-leading-none-static branch November 9, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant