Make leading-none
a static utility
#14934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
--leading-none
variable from the default theme in favor of makingleading-none
a static utility, since it doesn't make sense to change the value of this on a per-project basis. This is consistent with hownone
values work for other utilities in the framework.Some folks in the past have wanted
leading-none
to beline-height: 0
but technically "leading" is the space between lines, andline-height: 1
removes all extra space between lines so it feels correct to me (although it means all of the numeric utilities likeleading-6
are not technically correct but I try hard not to think about that too much).If someone wants
line-height: 0
they can useleading-0
in v4 since theleading-*
utilities inherit the spacing scale now.