Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure custom variants using the JS API have access to modifiers #14637

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

philipp-spiess
Copy link
Member

Fixes #14623

We didn't properly pass through modifiers for all custom variant calls. This PR fixes that.

@philipp-spiess philipp-spiess force-pushed the fix/ensure-variants-have-access-to-modifiers branch from 33ca3b7 to 627c8e4 Compare October 10, 2024 10:08
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha good catch

@philipp-spiess philipp-spiess merged commit df06003 into next Oct 10, 2024
1 check passed
@philipp-spiess philipp-spiess deleted the fix/ensure-variants-have-access-to-modifiers branch October 10, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants