-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate simple PostCSS setup #14612
Migrate simple PostCSS setup #14612
Conversation
c87d7d6
to
d2662d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some failing tests 🤔
Co-authored-by: Robin Malfait <[email protected]>
e5934fb
to
7494dd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments from my call with @RobinMalfait that I will fix up 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple things but otherwise looks good!
60fde28
to
ffd7417
Compare
This PR attempts to detect simple postcss setups: These are setups that do not load dynamic modules and are based off the examples we are recommending in our docs. We detect wether a config is appropriate by having it use the object plugin config and by not requiring any other modules:
When we find such a config file, we will go over it line-by-line and attempt to:
tailwindcss:
to'@tailwindcss/postcss':
autoprefixer
if usedWe then attempt to install and remove the respective npm packages based on the package manger we detect.
And since we now have logic to upgrade packages, this also makes sure to install
tailwindcss@next
at the end of a sucessful migration.