[v4] Support negative values for {col,row}-{start,end} utilities
#13780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/v4-grid-cols-negative
branch
from
7ee4a7c to
3538f9f
Compare
RobinMalfait
approved these changes
Jun 3, 2024
|
We should also add this for rows |
thecrypticace
force-pushed
the
feat/v4-grid-cols-negative
branch
from
3538f9f to
51ef8cf
Compare
thecrypticace
changed the title
col-start/col-end utilities{col,row}-{start,end} utilities
thecrypticace
force-pushed
the
feat/v4-grid-cols-negative
branch
from
51ef8cf to
f1bdadb
Compare
|
Added |
thecrypticace
changed the title
{col,row}-{start,end} utilities{col,row}-{start,end} utilities
RobinMalfait
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13754
Not including support for this seems to have been an oversight. We'll be backporting this to v3 as well.