Prevent scrolling when focusing a tab #2674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to the
<Tab>component that disables scrolling when focusing a tab button. While we want to focus the tab button, I don't think we want the default browser scroll-into-view behavior, as it creates weird issues like what you see in tailwindlabs/tailwindui-issues#1467. Here's a screen recording of that issue:Screen.Recording.2023-08-16.at.9.39.36.PM.mov
I think it's better to just preserve the existing scroll position than to try and have the browser scroll the tab button into focus. Here's what that looks like:
Screen.Recording.2023-08-16.at.9.46.27.PM.mov