Improve TypeScript 4.7 NodeNext
compatibility
#1721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the compatibility of the
NodeNext
module resolution in TypeScript 4.7.We already rewrote the imports to include the
.js
file, but we only did this for generated.js
files and not for generated
.d.ts
files.Ideally we don't have to do this rewrite on build files at all, and that is possible if we add the
.js
files to the actual source files. However this has some (annoying) issues:.js
files..js
file extension in the imports.Instead, for now, rewriting imports on
.d.ts
files as we already do with.js
file should do the trick,because then the
.js
extensiosn will be there in import/export statements.Fixes: #1699