Vkontakte provider and example of usage #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do think about my pull request? |
|
Hi! thanks, its a awesome works :) |
| @@ -118,6 +118,8 @@ object ApplicationBuild extends Build { | |||
| name := appName + "-social", | |||
| libraryDependencies += "com.typesafe.play" %% "play" % playVersion % "provided", | |||
| libraryDependencies += "com.typesafe.play" %% "play-ws" % playVersion % "provided", | |||
| libraryDependencies += "com.fasterxml.jackson.module" % "jackson-module-scala_2.10" % "2.7.2", | |||
| libraryDependencies += "net.minidev" % "json-smart" % "1.0.9", | |||
There was a problem hiding this comment.
Why do you introduce jackson and json-smart?
I want to decrease dependent libraries as possible.
Would you use play-json instead of it?
|
fixed |
|
Did you check my fix ? |
|
Hello, I need this changes for my site. I want to delete providers package from my code and use it from your lib. Where can you accept them and merge? |
|
Hi, what about my pull request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vkontakte. vk.com is a most popular social network in Russia and countries of post USSR.
More than 340 millions users.