Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix validateDOMNesting #145

Merged
merged 1 commit into from
Apr 19, 2017
Merged

fix validateDOMNesting #145

merged 1 commit into from
Apr 19, 2017

Conversation

zirho
Copy link
Contributor

@zirho zirho commented Apr 19, 2017 •
edited
Loading

ref: facebook/react#5071

I am not 100% sure this is right fix

webpack-for-frontend bundle is now VALID.
webpack-for-frontend Time: 267ms
Warning: validateDOMNesting(...): Whitespace text nodes cannot appear as a child of <head>. Make sure you don't have any extra whitespace between tags on each line of your source code. See Html > head > #text.
webpack-for-frontend bundle is now INVALID.
webpack-for-frontend bundle is now VALID.

Please close this if it's not

Thanks guys.

@larixer
Copy link
Member

larixer commented Apr 19, 2017 •
edited
Loading

I'm not sure !!__DEV__ is needed, but !!css seems to be the right thing. I am merging your fix though. Thank you Ji! I'm not 100% sure that this is your first name, pardon me if I'm wrong?

@larixer larixer merged commit eabd42b into sysgears:master Apr 19, 2017
@zirho
Copy link
Contributor Author

zirho commented Apr 19, 2017 •
edited
Loading

Thanks Victor,
You can call me Youngjae.
Ji is my last name. :) No apology needed

@zirho
Copy link
Contributor Author

zirho commented Apr 19, 2017

I'm working on one of my side projects with this.
Seeing pretty productive.
I hope I can contribute more along the way.

Thanks!

@larixer
Copy link
Member

larixer commented Apr 19, 2017

@zirho Sounds great! Looking forward to your next contribution! Thank you Youngjae!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zirho @larixer