Remove NoConstructorInTestRule as super narrow use case (#104)

symplify · Oct 19, 2023 · bb4027c · bb4027c
1 parent bd63c94
commit bb4027c
Show file tree

Hide file tree

Showing 11 changed files with 2 additions and 231 deletions.
diff --git a/config/static-rules.neon b/config/static-rules.neon
@@ -1,7 +1,6 @@
 rules:
     - Symplify\PHPStanRules\Rules\NoProtectedClassElementRule
     - Symplify\PHPStanRules\Rules\ForbiddenExtendOfNonAbstractClassRule
-    - Symplify\PHPStanRules\Rules\NoConstructorInTestRule
     - Symplify\PHPStanRules\Rules\Complexity\ForbiddenSameNamedNewInstanceRule
 
     # domain

diff --git a/docs/rules_overview.md b/docs/rules_overview.md
@@ -1,4 +1,4 @@
-# 49 Rules Overview
+# 48 Rules Overview
 
 ## AnnotateRegexClassConstWithRegexLinkRule
 
@@ -688,40 +688,6 @@ class SomeClass
 
 <br>
 
-## NoConstructorInTestRule
-
-Do not use constructor in tests. Move to `setUp()` method
-
-- class: [`Symplify\PHPStanRules\Rules\NoConstructorInTestRule`](../src/Rules/NoConstructorInTestRule.php)
-
-```php
-final class SomeTest
-{
-    public function __construct()
-    {
-        // ...
-    }
-}
-```
-
-:x:
-
-<br>
-
-```php
-final class SomeTest
-{
-    public function setUp()
-    {
-        // ...
-    }
-}
-```
-
-:+1:
-
-<br>
-
 ## NoDuplicatedShortClassNameRule
 
 Class with base "%s" name is already used in "%s". Use unique name to make classes easy to recognize

diff --git a/phpunit.xml b/phpunit.xml
@@ -2,7 +2,6 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" bootstrap="vendor/autoload.php" colors="true" xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd" cacheDirectory=".phpunit.cache">
     <testsuite name="all">
         <directory>tests</directory>
-        <exclude>tests/Rules/NoConstructorInTestRule/Fixture</exclude>
         <exclude>tests/Rules/ClassNameRespectsParentSuffixRule/Fixture/</exclude>
     </testsuite>
 </phpunit>
diff --git a/src/Enum/MethodName.php b/src/Enum/MethodName.php
@@ -6,11 +6,6 @@
 
 final class MethodName
 {
-    /**
-     * @var string
-     */
-    public const CONSTRUCTOR = '__construct';
-
     /**
      * @var string
      */

diff --git a/src/Rules/ClassNameRespectsParentSuffixRule.php b/src/Rules/ClassNameRespectsParentSuffixRule.php
@@ -49,7 +49,7 @@ final class ClassNameRespectsParentSuffixRule implements Rule, DocumentedRuleInt
     ];
 
     /**
-     * @var class-string[]
+     * @var string[]
      */
     private array $parentClasses = [];
 

diff --git a/src/Rules/NoConstructorInTestRule.php b/src/Rules/NoConstructorInTestRule.php
diff --git a/tests/Rules/NoConstructorInTestRule/Fixture/Test1/SkipTestWithoutConstructTest.php b/tests/Rules/NoConstructorInTestRule/Fixture/Test1/SkipTestWithoutConstructTest.php
diff --git a/tests/Rules/NoConstructorInTestRule/Fixture/Test2/SomeTest.php b/tests/Rules/NoConstructorInTestRule/Fixture/Test2/SomeTest.php
diff --git a/tests/Rules/NoConstructorInTestRule/Fixture/Test3/SkipTestWithoutParentTest.php b/tests/Rules/NoConstructorInTestRule/Fixture/Test3/SkipTestWithoutParentTest.php
diff --git a/tests/Rules/NoConstructorInTestRule/NoConstructorInTestRuleTest.php b/tests/Rules/NoConstructorInTestRule/NoConstructorInTestRuleTest.php
diff --git a/tests/Rules/NoConstructorInTestRule/config/configured_rule.neon b/tests/Rules/NoConstructorInTestRule/config/configured_rule.neon
-Original file line number
+Diff line change
@@ Expand Up @@
         ];
         /**
-         * @var class-string[]
+         * @var string[]
          */
         private array $parentClasses = [];
@@ Expand Down @@