Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added anchor for permissions #3628

Merged
merged 1 commit into from
Mar 12, 2014
Merged

Added anchor for permissions #3628

merged 1 commit into from
Mar 12, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Mar 3, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets -

This is quite a common problem on IRC. #symfony IRC now has a nice bot which parses the docs and indexes it, so we can easily link to sections (thanks to the great @mitom). If a sidebar doesn't have an anchor, it's impossible to link to it correctly. Adding a named anchor fixes that.

@cordoval
Copy link
Contributor

cordoval commented Mar 3, 2014

nice, is the bot usage documented somewhere? Thanks man!

@wouterj
Copy link
Member Author

wouterj commented Mar 3, 2014

@cordoval you mean how to use the bot?

@cordoval
Copy link
Contributor

cordoval commented Mar 3, 2014

precisely @wouterj (pronounced Wauter) 👶

@mitom
Copy link

mitom commented Mar 3, 2014

@cordoval you can find about how to improve it's results/contribute in it's repository

About how to use it, well typing !sf in #symfony would get you this very helpful message

@cordoval
Copy link
Contributor

cordoval commented Mar 3, 2014

👶 I will take a look at the state of @jakzal's bot then I want to keep my brain in PHP, but thanks!

@stof
Copy link
Member

stof commented Mar 3, 2014

@wouterj you should probably check other sidebars as well to verify they have an anchor

@wouterj
Copy link
Member Author

wouterj commented Mar 3, 2014

@stof I believe almost none has one. However, most sidebars contain "side information". This one contains actually really important information, so I decided to add it (well, @mitom told me to do it :P).

But feel free to add more anchors if you think it'll be used much.

@weaverryan
Copy link
Member

This is a very good idea - nice work Wouter!

weaverryan added a commit that referenced this pull request Mar 12, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Added anchor for permissions

| Q   | A
| --- | ---
| Doc fix? | yes
| New docs? | no
| Applies to | all
| Fixed tickets | -

This is quite a common problem on IRC. #symfony IRC now has a nice bot which parses the docs and indexes it, so we can easily link to sections (thanks to the great @mitom). If a sidebar doesn't have an anchor, it's impossible to link to it correctly. Adding a named anchor fixes that.

Commits
-------

f42956a Added anchor for permissions
@weaverryan weaverryan merged commit f42956a into 2.3 Mar 12, 2014
@wouterj wouterj deleted the permissions-anchor branch March 12, 2014 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants