Create data_class.rst.inc #2362 #3334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dpcat237
commented
Dec 14, 2013
dpcat237
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | 2.3+ |
| Fixed tickets | #2362 |
Create data_class documentation.
15 tasks
| $builder->add('media', 'sonata_media_type', array( | ||
| 'data_class' => 'Acme\DemoBundle\Entity\Media', | ||
| )); | ||
|
|
|
As I already said on your other PR, this option has to be included in some relevant form type docs |
|
@wouterj Do I have to do something else in this pull request? |
|
@dpcat237 we can also add this option to the base Form type, as it also exists there. |
| @@ -0,0 +1,11 @@ | |||
| data_class | |||
There was a problem hiding this comment.
you should add a versionadded directive before this line:
.. versionadded:: 2.4
The ``data_class`` option was introduced in Symfony 2.4.
There was a problem hiding this comment.
But this isn't correct, right? The data_class option has always existed.
There was a problem hiding this comment.
Yes, indeed. You're correct https://gist.github.com/WouterJ/5246728#file-tree-L100
weaverryan
pushed a commit
that referenced
this pull request
Jan 1, 2014
weaverryan
pushed a commit
that referenced
this pull request
Jan 1, 2014
|
Thanks Denys! I've patched this into the 2.3 branch at sha: 00f4d31. Nice work with this and thanks for hanging out with us on the Hack Day :). Cheers! |
xabbuh
added a commit
to xabbuh/symfony-docs
that referenced
this pull request
Jan 3, 2014
weaverryan
added a commit
that referenced
this pull request
Jan 9, 2014
…bbuh) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #3415). Discussion ---------- [#3334] the data_class option was not introduced in 2.4 | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | Commits ------- c96e6eb [#3334] the data_class option was not introduced in 2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.