Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Social media icons should have a label title for the screenreader #594

Closed
2 tasks done
bit-pro-iew-eui opened this issue Nov 17, 2017 · 2 comments
Closed
2 tasks done

Social media icons should have a label title for the screenreader #594

bit-pro-iew-eui opened this issue Nov 17, 2017 · 2 comments
Assignees
@gillerr
Labels
accessibility
Milestone
3.2

Comments

@bit-pro-iew-eui
Copy link
Contributor

bit-pro-iew-eui commented Nov 17, 2017 •
edited by gillerr
Loading

  • Social media icons should have a label "Social Media" only for the screenreader, not visible.

https://swiss.github.io/styleguide/de/footer.html#04-footer-02-social-media

image

  • Please add a label also for "Social Media Sharing"

https://swiss.github.io/styleguide/de/functions.html#04-functions-02-social-sharing
@bit-pro-iew-eui bit-pro-iew-eui added this to the Next milestone Nov 17, 2017
@gillerr
Copy link
Contributor

gillerr commented Nov 21, 2017

Simply add a label with sr-only class to the nav element

@bit-pro-iew-eui bit-pro-iew-eui assigned vanquix and gillerr and unassigned vanquix Nov 30, 2017
gillerr added a commit that referenced this issue Dec 7, 2017
@gillerr
fix(socialMedia): add a heading for screen reader
2b884d7 
#594
gillerr added a commit that referenced this issue Dec 7, 2017
@gillerr
fix(socialSharing): add a heading for screen reader
72aeb1f 
#594
@bit-pro-iew-eui bit-pro-iew-eui modified the milestones: 3.3, 3.2 Dec 7, 2017
@bit-pro-iew-eui
Copy link
Contributor Author

Please don't use H1-6 use another html-tag which is read by at least NVDA

gillerr added a commit that referenced this issue Dec 11, 2017
@gillerr
fix: use label instead of headings for screen reader only titles
6aa6a1e 
Closes #594
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@gillerr gillerr

Labels
accessibility
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@gillerr @bit-pro-iew-eui @vanquix