Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Close icon in search, misses a label for accessibility #591

Closed
bit-pro-iew-eui opened this issue Nov 10, 2017 · 1 comment
Closed

Close icon in search, misses a label for accessibility #591

bit-pro-iew-eui opened this issue Nov 10, 2017 · 1 comment
Assignees
@almeidap
Labels
accessibility
Milestone
3.2

Comments

@bit-pro-iew-eui
Copy link
Contributor

bit-pro-iew-eui commented Nov 10, 2017 •
edited
Loading

The "X" of the search box should have a label for better accessibility
English "Reset search field"
Deutsch "Suchfeld zurücksetzen"
French: "Réinitialiser le champ de recherche"

image

Please put this label also in the search of the guideline itself
Please update the release notes, for this

https://swiss.github.io/styleguide/de/header.html#02-header-04-site-search
@bit-pro-iew-eui bit-pro-iew-eui added this to the Next milestone Nov 10, 2017
@bit-pro-iew-eui bit-pro-iew-eui assigned gillerr and almeidap and unassigned gillerr Nov 30, 2017
@bit-pro-iew-eui bit-pro-iew-eui modified the milestones: Next, 3.2 Nov 30, 2017
@bit-pro-iew-eui
Copy link
Contributor Author

NVDA Reader does not read the span-tag, and it's not accessible with the keyboard

almeidap added a commit that referenced this issue Dec 12, 2017
@almeidap
Rework search widget (.search-input) for better accessibility. Closes
21335cd 
#599 & #591.

BREAKING CHANGES: the search widget now uses a different HTML markup. Please, refer to the docs for the right structure to use.
@almeidap almeidap mentioned this issue Dec 12, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@almeidap almeidap

Labels
accessibility
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@almeidap @gillerr @bit-pro-iew-eui