Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Do not use heading-tags in search results #496

Closed
ccweb opened this issue Nov 15, 2016 · 2 comments
Closed

Do not use heading-tags in search results #496

ccweb opened this issue Nov 15, 2016 · 2 comments
Assignees
@almeidap
Milestone
3.2

Comments

@ccweb
Copy link

ccweb commented Nov 15, 2016 •
edited
Loading

The six heading elements, H1 through H6, must be used to denote section headings.
<h4><a href="#">Title of the first result</a></h4>
Remove the <h4>-tags and style the <a>-tags accordingly.
@bit-pro-iew-eui bit-pro-iew-eui self-assigned this Feb 9, 2017
@bit-pro-iew-eui
Copy link
Contributor

This issue can be implemented at the same time as #477, #515, #488

This was referenced Mar 9, 2017
Closed
Open
@bit-pro-iew-eui bit-pro-iew-eui removed their assignment Mar 9, 2017
@bit-pro-iew-eui bit-pro-iew-eui added this to the Next milestone Sep 29, 2017
topaxi added a commit to topaxi/styleguide that referenced this issue Oct 2, 2017
@topaxi
Don't use headings in search results
2f3ad3e 
Fixes swiss#496
@topaxi topaxi mentioned this issue Oct 2, 2017
Merged
@bit-pro-iew-eui bit-pro-iew-eui assigned almeidap and unassigned topaxi Nov 30, 2017
@bit-pro-iew-eui bit-pro-iew-eui modified the milestones: Next, 3.2 Nov 30, 2017
@angelogti
Copy link
Collaborator

Heading tags are still used as titles of the search results:

image

(chrome, https://admin-ch.github.io/styleguide/en/search.html#07-search-02-search-results)

@angelogti angelogti reopened this Dec 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@almeidap almeidap

Labels
None yet
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
6 participants
@almeidap @topaxi @ccweb @mbruellmann @bit-pro-iew-eui @angelogti