Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Displacement of content when using LightBox #495

Closed
suterma opened this issue Oct 24, 2016 · 2 comments · Fixed by #577
Closed

Displacement of content when using LightBox #495

suterma opened this issue Oct 24, 2016 · 2 comments · Fixed by #577
Assignees
@bihorco36
Milestone
3.2

Comments

@suterma
Copy link
Contributor

suterma commented Oct 24, 2016 •
edited
Loading

When using the Lightbox-Example in https://swiss.github.io/styleguide/de/multimedia.html#06-multimedia-03-lightbox, as soon as the modal dialog is shown, the underlying page gets displaced by visually notable amount of pixels. This seems to be caused by this additional element style, which is added to the document body on showing the modal dialog:

<body style="padding-right: 17px;" class="modal-open">

The problem is probably somewhere in the javascript code that handles the modal dialog fades.
@bit-pro-iew-eui bit-pro-iew-eui self-assigned this Feb 9, 2017
@bit-pro-iew-eui
Copy link
Contributor

@suterma I can't reproduce the issue. Can you provide which steps should be followed, browser name, browser version?

@bit-pro-iew-eui bit-pro-iew-eui removed their assignment Feb 9, 2017
@suterma
Copy link
Contributor Author

suterma commented Jun 25, 2017 •
edited
Loading

This issue is still valid today. I have tested on a recent Chrome Browser Version 59.0.3071.104 (Official Build) (64-bit) on Ubuntu 14.04. See attached Screenshots. It occurs on all window widths from small to very large. Attached you find 2 images, one before loading the modal dialog, one with the dialog show. Notice the slightly left-shifted content in the background.
without-dialog
with-dialog

It's not much, but clearly noticeable. Probably the width of the scrollbar.

@bit-pro-iew-eui bit-pro-iew-eui added this to the Next milestone Nov 1, 2017
bihorco36 added a commit to bihorco36/styleguide that referenced this issue Nov 2, 2017
@bihorco36
fixed content displacement when opening modal swiss#495
365b497
@bihorco36 bihorco36 mentioned this issue Nov 2, 2017
Merged
@bit-pro-iew-eui bit-pro-iew-eui modified the milestones: Next, 3.2 Nov 30, 2017
almeidap added a commit that referenced this issue Dec 4, 2017
@almeidap
Merge pull request #577 from janissbinder/495
be45e36 
fixed content displacement when opening modal #495
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bihorco36 bihorco36

Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

fixed content displacement when opening modal #495 bihorco36/styleguide
4 participants
@bihorco36 @mbruellmann @bit-pro-iew-eui @suterma