fix(megaMenu): use a button instead of a link with role="menuitem"

#552
swiss · Dec 6, 2017 · 5be9a5a · 5be9a5a
1 parent 21a8f57
commit 5be9a5a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/src/assets/sass/components/mega-menu.scss b/src/assets/sass/components/mega-menu.scss
@@ -46,6 +46,7 @@
   border-top: 1px solid $silver !important;
   border-left: 1px solid $silver;
   border-right: 1px solid $silver;
+  border-bottom: 0;
   text-align: center;
   color: $coal;
   &:hover {
@@ -61,4 +62,4 @@
 .nav-main.yamm .nav .dropdown-menu li:hover a {
   padding-bottom: auto !important;
   border-top: auto !important;
-}
+}
diff --git a/src/views/layouts/includes/f-menu-item.html b/src/views/layouts/includes/f-menu-item.html
@@ -24,7 +24,7 @@ <h4><a href="{{#if @root.baseurl}}{{@root.baseurl}}/{{/if}}../{{data 'locale'}}/
           {{/modulo}}
         {{/each}}
       </div>
-      <a href="#" class="yamm-close-bottom" role="menuitem" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top"></span></a>
+      <button class="yamm-close-bottom" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top"></span></button>
     </div>
   </div>
 </li>
diff --git a/src/views/layouts/includes/f-menu.html b/src/views/layouts/includes/f-menu.html
@@ -45,7 +45,7 @@ <h1><a href="{{#if baseurl}}{{baseurl}}/{{/if}}../{{data 'locale'}}/">{{t 'style
                   </nav>
                 </li>
               </ul>
-              <a href="#" class="yamm-close-bottom" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top" aria-hidden="true"></span></a>
+              <button class="yamm-close-bottom" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top" aria-hidden="true"></span></button>
             </nav>
 
           </div>
@@ -101,7 +101,7 @@ <h4><a href="{{#if @root.baseurl}}{{@root.baseurl}}/{{/if}}../{{data 'locale'}}/
             {{/modulo}}
             {{/each}}
           </div>
-          <a href="#" class="yamm-close-bottom" role="menuitem" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top"></span></a>
+          <button class="yamm-close-bottom" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top"></span></button>
         </div>
       </div>
     </li>
@@ -136,7 +136,7 @@ <h4><a href="{{#if @root.baseurl}}{{@root.baseurl}}/{{/if}}../{{data 'locale'}}/
             {{/modulo}}
             {{/each}}
           </div>
-          <a href="#" class="yamm-close-bottom" role="menuitem" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top"></span></a>
+          <button class="yamm-close-bottom" aria-label="{{t 'styleguide.close'}}"><span class="icon icon--top"></span></button>
         </div>
       </div>
     </li>