fix(megaMenu): use a button instead of a link with `role="menuitem"…

…` for leading close button #552
swiss · Dec 6, 2017 · 4481749 · 4481749
1 parent 520ad84
commit 4481749
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/views/layouts/includes/f-menu-item.html b/src/views/layouts/includes/f-menu-item.html
@@ -3,7 +3,7 @@
   <div class="dropdown-menu" role="menu">
     <div class="yamm-content container-fluid">
       <div class="row">
-        <div class="col-sm-12"><a href="#" class="yamm-close icon icon--after icon--close pull-right" role="menuitem" tabindex="-1">{{t 'styleguide.close'}}</a></div>
+        <div class="col-sm-12"><button class="yamm-close btn btn-link icon icon--after icon--close pull-right">{{t 'styleguide.close'}}</button></div>
       </div>
       <div class="row">
         {{#each items}}

diff --git a/src/views/layouts/includes/f-menu.html b/src/views/layouts/includes/f-menu.html
@@ -80,7 +80,7 @@ <h2 class="sr-only">{{t 'styleguide.global-search.title'}}</h2>
       <div class="dropdown-menu" role="menu">
         <div class="yamm-content container-fluid">
           <div class="row">
-            <div class="col-sm-12"><a href="#" class="yamm-close icon icon--after icon--close pull-right" role="menuitem" tabindex="-1">{{t 'styleguide.close'}}</a></div>
+            <div class="col-sm-12"><button class="yamm-close btn btn-link icon icon--after icon--close pull-right">{{t 'styleguide.close'}}</button></div>
           </div>
           <div class="row">
             {{#each views.docs.items}}
@@ -115,7 +115,7 @@ <h4><a href="{{#if @root.baseurl}}{{@root.baseurl}}/{{/if}}../{{data 'locale'}}/
       <div class="dropdown-menu" role="menu">
         <div class="yamm-content container-fluid">
           <div class="row">
-            <div class="col-sm-12"><a href="#" class="yamm-close icon icon--after icon--close pull-right" role="menuitem" tabindex="-1">{{t 'styleguide.close'}}</a></div>
+            <div class="col-sm-12"><button class="yamm-close btn btn-link icon icon--after icon--close pull-right">{{t 'styleguide.close'}}</button></div>
           </div>
           <div class="row">
             {{#each views.pages.items}}