Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit reabstraction thunks for implicit conversions between T.TangentType and Optional<T>.TangentType #78076

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Emit reabstraction thunks for implicit conversions between T.TangentType and Optional<T>.TangentType #78076

wants to merge 3 commits into from

Conversation

asl
Copy link
Contributor

@asl asl commented Dec 10, 2024 •
edited
Loading

Fixes #77871

@asl asl requested review from rxwei and hamishknight December 10, 2024 00:47
@asl
Copy link
Contributor Author

asl commented Dec 10, 2024

Tagging @JaapWijnen

@asl asl force-pushed the diff-opt-implicit-conversion branch from 49b7a36 to 5a68861 Compare December 10, 2024 00:51
@asl
Copy link
Contributor Author

asl commented Dec 10, 2024

@swift-ci Please test

@asl asl requested a review from slavapestov December 10, 2024 22:29
@asl
Copy link
Contributor Author

asl commented Dec 10, 2024

@swift-ci please test

@asl
Copy link
Contributor Author

asl commented Dec 20, 2024

@slavapestov @hamishknight ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei Awaiting requested review from rxwei

@hamishknight hamishknight Awaiting requested review from hamishknight

@hborla hborla Awaiting requested review from hborla hborla is a code owner

@xedin xedin Awaiting requested review from xedin xedin is a code owner

@jckarter jckarter Awaiting requested review from jckarter jckarter is a code owner

@slavapestov slavapestov Awaiting requested review from slavapestov slavapestov is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in silgen due to missed / failed typecheck
2 participants
@asl @slavapestov