[lldb] Implement a formatter bytecode interpreter in C++ #9711
+3,899
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
adrian-prantl
requested review from
kastiglione and
JDevlieghere
and removed request for
a team
|
Intentionally not cherry-picking to 6.1, since this is still experimental. |
adrian-prantl
force-pushed
the
cherry-pick-bytecode
branch
from
86b412b to
c49aeda
Compare
|
@swift-ci test |
|
@swift-ci test windows |
adrian-prantl
force-pushed
the
cherry-pick-bytecode
branch
from
c49aeda to
967c14e
Compare
|
@swift-ci test |
Improve the chance of resolving file/line breakpoints by realpath'ing the support files before doing a second match attempt, with some conditions applied. A working [hello-world example](https://github.com/royitaqi/lldb_demos/blob/main/realpath/README.md). See [patch](llvm#102223) for more info about problem/motivation, details of the feature, new settings, telemetries and tests. (cherry picked from commit 47721d4)
…providers within lldb (llvm#102708) This PR adds a statistics provider cache, which allows an individual target to keep a rolling tally of it's total time and number of invocations for a given summary provider. This information is then available in statistics dump to help slow summary providers, and gleam more into insight into LLDB's time use. (cherry picked from commit 22144e2)
"statistics dump" currently report the statistics of all targets in debugger instead of current target. This is wrong because there is a "statistics dump --all-targets" option that supposed to include everything. This PR fixes the issue by only report statistics for current target instead of all. It also includes the change to reset statistics debug info/symbol table parsing/indexing time during debugger destroy. This is required so that we report current statistics if we plan to reuse lldb/lldb-dap across debug sessions --------- Co-authored-by: jeffreytan81 <[email protected]> (cherry picked from commit 24feaab)
…examples This PR adds a proof-of-concept for a bytecode designed to ship and run LLDB data formatters. More motivation and context can be found in the formatter-bytecode.rst file and on discourse. https://discourse.llvm.org/t/a-bytecode-for-lldb-data-formatters/82696 Relanding with a fix for a case-sensitive path. (cherry picked from commit fffe8c6)
(cherry picked from commit 9f98949)
Compared to the python version, this also does type checking and error handling, so it's slightly longer, however, it's still comfortably under 500 lines. (cherry picked from commit 9a9c1d4)
(cherry picked from commit e2bb474)
(cherry picked from commit 0be3348)
(cherry picked from commit d300337)
(cherry picked from commit f6012a2)
…vm#119620) This trips UBSAN and probably isn't partiuclarly useful either. (cherry picked from commit 2470cfa)
(cherry picked from commit 373a93b)
adrian-prantl
force-pushed
the
cherry-pick-bytecode
branch
from
967c14e to
5119325
Compare
|
@swift-ci test |
The build break was caused by a [previous patch](llvm#102223) using `PATH_MAX` which is undefined in Windows. (cherry picked from commit f377edb)
…104502) # Part 1: Correctly fix a usage of `PATH_MAX` TL;DR: Adding a typedef `lldb_private::PathSmallString` which contains a hardcoded initial size (128). # Part 2: Fix unit tests After llvm#104493 fixed the build break for Windows, unit test failure showed up for Windows. The root-cause is that the `FileSpec`'s in the unit tests are not style-specific. The fix is to apply either `WindowsSpec` or `PosixSpec` specifically. (cherry picked from commit 26670e7)
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.