fix: types in keydown-handler.js

sweetalert2 · Nov 30, 2022 · 51f05b0 · 51f05b0
1 parent 3927058
commit 51f05b0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/SweetAlert.js b/src/SweetAlert.js
@@ -290,7 +290,7 @@ Object.assign(SweetAlert, staticMethods)
 Object.keys(instanceMethods).forEach((key) => {
   /**
    * @param {...any} args
-   * @returns {any}
+   * @returns {any | undefined}
    */
   SweetAlert[key] = function (...args) {
     if (currentInstance) {

diff --git a/src/instanceMethods/_destroy.js b/src/instanceMethods/_destroy.js
@@ -2,6 +2,9 @@ import globalState from '../globalState.js'
 import privateMethods from '../privateMethods.js'
 import privateProps from '../privateProps.js'
 
+/**
+ * Dispose the current SweetAlert2 instance
+ */
 export function _destroy() {
   const domCache = privateProps.domCache.get(this)
   const innerParams = privateProps.innerParams.get(this)

diff --git a/src/keydown-handler.js b/src/keydown-handler.js
@@ -55,7 +55,8 @@ export const setFocus = (innerParams, index, increment) => {
       index = focusableElements.length - 1
     }
 
-    return focusableElements[index].focus()
+    focusableElements[index].focus()
+    return
   }
   // no visible focusable elements, focus the popup
   dom.getPopup().focus()
@@ -68,7 +69,7 @@ const arrowKeysPreviousButton = ['ArrowLeft', 'ArrowUp']
 /**
  * @param {SweetAlert2} instance
  * @param {KeyboardEvent} e
- * @param {function} dismissWith
+ * @param {Function} dismissWith
  */
 const keydownHandler = (instance, e, dismissWith) => {
   const innerParams = privateProps.innerParams.get(instance)
@@ -198,7 +199,7 @@ const handleArrows = (key) => {
 /**
  * @param {KeyboardEvent} e
  * @param {SweetAlertOptions} innerParams
- * @param {function} dismissWith
+ * @param {Function} dismissWith
  */
 const handleEsc = (e, innerParams, dismissWith) => {
   if (callIfFunction(innerParams.allowEscapeKey)) {