Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Add type check to & and | #8965

Merged
merged 6 commits into from
May 22, 2024
Merged

fix(es/minifier): Add type check to & and | #8965

merged 6 commits into from
May 22, 2024
+32 −7

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 21, 2024

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone May 21, 2024
@kdy1 kdy1 self-assigned this May 21, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c74338d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 commented May 21, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_utils
  • swc_ecma_minifier
  • swc_core

@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug fix(es/minifier): Remove wrong code about & May 21, 2024
@kdy1 kdy1 changed the title fix(es/minifier): Remove wrong code about & fix(es/minifier): Remove wrong code about & and | May 21, 2024
@kdy1 kdy1 marked this pull request as ready for review May 21, 2024 12:30
@kdy1 kdy1 requested a review from a team as a code owner May 21, 2024 12:30
kodiakhq[bot]
kodiakhq bot previously approved these changes May 21, 2024
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) May 21, 2024 12:34
kodiakhq[bot]
kodiakhq bot previously approved these changes May 21, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes May 21, 2024
View reviewed changes
@kdy1 kdy1 changed the title fix(es/minifier): Remove wrong code about & and | fix(es/minifier): Add type check to & and | May 21, 2024
kodiakhq[bot]
kodiakhq bot previously approved these changes May 21, 2024
View reviewed changes
Austaras
Austaras previously approved these changes May 21, 2024
View reviewed changes
@kdy1 kdy1 disabled auto-merge May 22, 2024 00:05
@kdy1 kdy1 dismissed stale reviews from Austaras and kodiakhq[bot] via c74338d May 22, 2024 02:13
@kdy1 kdy1 merged commit 545ec51 into swc-project:main May 22, 2024
147 checks passed
@kdy1 kdy1 deleted the issue-8964 branch May 22, 2024 02:27
@kdy1 kdy1 modified the milestones: Planned, v1.5.9 May 28, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@Austaras Austaras Austaras left review comments

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.9
Development

Successfully merging this pull request may close these issues.

Minify error: evaluate error in inline function
2 participants
@kdy1 @Austaras