build(cargo): use lld for win x64 build #3683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note i686 doesn't do this - it fails to build. |
|
Is zld helpful for swc? bevyengine/bevy#312 |
|
Zld and other (mold for example for linux) is in consideration, just couldn't spend time to setup CI & make it required for local dev. If there's poc shows meaningful gain we can definitely try. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR attempts to try new linker for the builds. As first step, replaces x64 windows build to use lld. Instead of using separate llvm installation for lld which can be verbose to setup this uses out-of-the box lld comes with rustc.
Consider this as an expriment, this may not improve performance drastically. Guess we can try & see.
BREAKING CHANGE:
Related issue (if exists):