Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support openapiV3 oneOf for fields/responses" #1699

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Nov 7, 2023

Reverts #1671

  • Unit test failing

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37dac67) 79.43% compared to head (969b4ad) 79.43%.
Report is 1 commits behind head on v2.

❗ Current head 969b4ad differs from pull request most recent head 8d43f6d. Consider uploading reports for the commit 8d43f6d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #1699   +/-   ##
=======================================
  Coverage   79.43%   79.43%           
=======================================
  Files          21       21           
  Lines        5606     5606           
=======================================
  Hits         4453     4453           
  Misses        975      975           
  Partials      178      178           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ubogdan ubogdan merged commit 687052e into v2 Nov 7, 2023
7 of 8 checks passed
@ubogdan ubogdan deleted the revert-1671-feat-openapiv3-oneof branch November 7, 2023 07:46
@thzois
Copy link

thzois commented Dec 13, 2023

Hello @ubogdan, as this feature is reverted, is there any way atm in v2 to have the oneOf feature?

@wanna-beat-by-bit
Copy link

I wish that feature came out

@BenukEl
Copy link

BenukEl commented Jan 31, 2024

Is this feature available in V1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants