Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alias type of generic with multi formal params #1505

Merged
merged 3 commits into from
Mar 20, 2023
Merged

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Mar 19, 2023

Describe the PR
fix bug: alias type of generc with multi formal params

Relation issue
#1489

@sdghchj sdghchj changed the title fix generic alias type fix alias type of generic with multi formal params Mar 20, 2023
Signed-off-by: sdghchj <[email protected]>
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Patch coverage: 86.66% and no project coverage change.

Comparison is base (aa3e8d5) 85.14% compared to head (c76afc6) 85.15%.

❗ Current head c76afc6 differs from pull request most recent head de02797. Consider uploading reports for the commit de02797 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
  Coverage   85.14%   85.15%           
=======================================
  Files          19       19           
  Lines        3616     3630   +14     
=======================================
+ Hits         3079     3091   +12     
- Misses        459      460    +1     
- Partials       78       79    +1     
Impacted Files Coverage Δ
gen/gen.go 93.51% <ø> (ø)
field_parser.go 96.90% <33.33%> (-0.55%) ⬇️
generics.go 100.00% <100.00%> (ø)
operation.go 96.11% <100.00%> (+0.01%) ⬆️
parser.go 94.50% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sdghchj sdghchj requested a review from ubogdan March 20, 2023 02:48
@sdghchj sdghchj merged commit d2bc3d0 into master Mar 20, 2023
@sdghchj sdghchj deleted the generic-fix branch March 20, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants