Hotfix/out of memory error 6394 #7625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariota
suggested changes
May 11, 2018
| @@ -1,18 +1,39 @@ | |||
| package io.swagger.codegen.examples; | |||
|
|
|||
| import static io.swagger.models.properties.StringProperty.Format.URI; | |||
There was a problem hiding this comment.
All of these changes to the imports are unnecessary - could you change them back to how they were?
There was a problem hiding this comment.
because of the automatically format of IntelliJ. And I have changed the import back.
| @@ -179,6 +179,7 @@ private Object resolvePropertyToExample(String propertyName, String mediaType, P | |||
| if (innerType != null) { | |||
| int arrayLength = null == ((ArrayProperty) property).getMaxItems() ? 2 : ((ArrayProperty) property).getMaxItems(); | |||
| if(arrayLength>10000) { | |||
| logger.warn("The max item is too large to new Object array and set it to 10000, the previous value is {}", arrayLength); | |||
There was a problem hiding this comment.
This warning message is a bit unclear. Could you change it to something like logger.warn("The max items allowed in property {} is too large ({} items), restricting it to 10,000 items", property, arrayLength)?
dariota
approved these changes
May 13, 2018
Closed
Wagan8r
added a commit
to Wagan8r/swagger-codegen
that referenced
this pull request
Jan 24, 2019
Applied the fix listed in a PR on the official swagger-codegen project: swagger-api#7625. The maintainers are dragging their feet on merging it...
|
Thanks for the PR; a fix, limiting to 10 examples, has been applied in #9553, therefore closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Hotfix for the issue #6394