[Clojure] Improve api name for the Clojure client #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, when an operation's tag is "users-api", "users_api" or "UsersApi", generate the api file named users_api.clj and "users-api" as the namespace (it was "usersapi.clj" and "usersapi" before). To implement this, I have to move the "sanitizeTag" method from DefaultGenerator.java to DefaultCodegen.java so that its behaviour can be overridden in ClojureClientCodegen.java, which is needed as the default implementation would sanitize "users-api" to "usersapi" before the tag is passed to "toApiName" and "toApiFilename".
wing328
added a commit
that referenced
this pull request
Mar 2, 2016
[Clojure] Improve api name for the Clojure client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, when an operation's tag is
users-api,users_apiorUsersApi, generate the api file namedusers_api.cljandusers-apias the namespace (it wasusersapi.cljandusersapibefore).To implement this, I have to move the
sanitizeTagmethod from DefaultGenerator.java to DefaultCodegen.java so that its behaviour can be overridden in ClojureClientCodegen.java, which is needed as the default implementation would sanitizeusers-apitousersapibefore the tag is passed totoApiNameandtoApiFilename.