Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip trailing comma for enums in TypeScript angular #1886

Merged
merged 3 commits into from
Jan 15, 2016
Merged

skip trailing comma for enums in TypeScript angular #1886

merged 3 commits into from
Jan 15, 2016

Conversation

bakito
Copy link
Contributor

@bakito bakito commented Jan 14, 2016

This change skips the trailing comma for enums in angular TypeScript models.

@wing328 wing328 added this to the v2.1.6 milestone Jan 14, 2016
@wing328
Copy link
Contributor

wing328 commented Jan 14, 2016

@bakito thanks for the PR. Does typescript-node need similar change? If yes, do you mind including that in this PR?

Also please update the Petstore sample as mentioned in the guidelines for contributing: https://github.com/swagger-api/swagger-codegen/wiki/Guidelines-for-Contribution

@bakito
Copy link
Contributor Author

bakito commented Jan 14, 2016

I don't find any link between my commit and the build error that it caused.

Failed tests: testCreateUsersWithArray(io.swagger.petstore.test.UserApiTest): expected:<1452772958870> but was:<1452772958808>

Has anybody an idea?

@wing328
Copy link
Contributor

wing328 commented Jan 14, 2016

@bakito I'll look into the CI build error.

@wing328
Copy link
Contributor

wing328 commented Jan 14, 2016

Restarted the CI job and the result is now ok.

@bakito
Copy link
Contributor Author

bakito commented Jan 14, 2016

I've added the node template too.

I've also updated the petshop files.
The generated changes where mainly generation Timestamps and missing implementations of getPetByIdWithByteArrayWithCompletion addPetUsingByteArrayWithCompletion. I could not find any changes resulting of my commits.

Do I really have to commit these changes?

@wing328
Copy link
Contributor

wing328 commented Jan 14, 2016

We usually update the sample as part of the PR. The new methods are recently added for testing the support of binary format.

I would recommend you to commit these changes if you've time.

@bakito
Copy link
Contributor Author

bakito commented Jan 14, 2016

I committed the changes made in the angularjs and node modules, but without the binary stuff. I could not get the tests running with binary.

@wing328
Copy link
Contributor

wing328 commented Jan 14, 2016

The binary stuff does not work likely due to the fact that there's no type mapping for binary. Please ignore that for the time being as we add support of binary language by language.

@bakito
Copy link
Contributor Author

bakito commented Jan 14, 2016

My changes should be ok then, or is still something missing?

@wing328
Copy link
Contributor

wing328 commented Jan 14, 2016

Looks good to me. Will take another look tomorrow and merge accordingly.

wing328 added a commit that referenced this pull request Jan 15, 2016
skip trailing comma for enums in TypeScript angular
@wing328 wing328 merged commit 56f8d5f into swagger-api:master Jan 15, 2016
@wing328
Copy link
Contributor

wing328 commented Jan 15, 2016

PR merged. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants