-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip trailing comma for enums in TypeScript angular #1886
Conversation
@bakito thanks for the PR. Does typescript-node need similar change? If yes, do you mind including that in this PR? Also please update the Petstore sample as mentioned in the guidelines for contributing: https://github.com/swagger-api/swagger-codegen/wiki/Guidelines-for-Contribution |
I don't find any link between my commit and the build error that it caused. Failed tests: testCreateUsersWithArray(io.swagger.petstore.test.UserApiTest): expected:<1452772958870> but was:<1452772958808> Has anybody an idea? |
@bakito I'll look into the CI build error. |
Restarted the CI job and the result is now ok. |
I've added the node template too. I've also updated the petshop files. Do I really have to commit these changes? |
We usually update the sample as part of the PR. The new methods are recently added for testing the support of I would recommend you to commit these changes if you've time. |
I committed the changes made in the angularjs and node modules, but without the binary stuff. I could not get the tests running with binary. |
The binary stuff does not work likely due to the fact that there's no type mapping for |
My changes should be ok then, or is still something missing? |
Looks good to me. Will take another look tomorrow and merge accordingly. |
skip trailing comma for enums in TypeScript angular
PR merged. Thanks for the contribution. |
This change skips the trailing comma for enums in angular TypeScript models.