Android volley fix responses with additionalProperties and update sdk version #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, please rebase with master. The |
Shyri
force-pushed
the
android-volley-library
branch
from
f852f9f to
77f9f13
Compare
…resent. Clean responses mechanism using volley default's
Shyri
force-pushed
the
android-volley-library
branch
from
77f9f13 to
4261fe4
Compare
|
@fehguy done! :) |
|
@Shyri thanks for the PR. When you've time, I wonder if you can write some tests case for Petstore sample (android-volley) similar to https://github.com/swagger-api/swagger-codegen/tree/master/samples/client/petstore/android/default/src/test/java/io/swagger/petstore/test. |
|
@wing328 Ook no problem. I'll write them when I have a moment. Should I send a new PR for that or force it into this one? |
wing328
added a commit
that referenced
this pull request
Jan 11, 2016
Android volley fix responses with additionalProperties and update sdk version
|
@Shyri just merged this PR. Please open a new one for the enhancement when you've time. |
This was referenced Jan 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
as @xhh stated in #1775 there was an error with responses. I removed the
Responses.javastatic class an replaced Response listener with baseResponse.Listener<T>from Volley library, I think is much cleaner, the intermediate class with a lot of interfaces is not necesary . Don't know why I didn't think about it earlier.Also I updated to
compileSdkVersion 23buildToolsVersion '23.0.2'andtargetSdkVersion 23