proposal for #807, includes #550, SVG.off() multiple events and option argument
#808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)` and add option argument
Fuzzyma
force-pushed
the
events-memory-leak
branch
from
d6cb547 to
9569005
Compare
saivan
approved these changes
Feb 27, 2018
| expect(Object.keys(SVG.listeners[SVG.handlerMap.indexOf(rect3.node)]['event']['*']).length).toBe(2) // 2 listener on rect3 | ||
|
|
||
| expect(SVG.listeners.length).toBe(listenerCnt + 3) // added listeners on 3 different elements | ||
| expect(Object.keys(rect.events['event']['*']).length).toBe(1) // 1 listener on rect |
There was a problem hiding this comment.
The star is a wildcard namespace. So every event not bound to a particular namespace will get saved under the wildcard namespace
There was a problem hiding this comment.
Maybe though, it should be clearer? Maybe something like 'default'?
There was a problem hiding this comment.
I just wanted to take something which wouldnt be used by the user on accident
|
Go ahead and merge this and close its relevant issues if you're happy with it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is Work in Progress.
It moves the event handlers on the node as discussed in #807. It also changes #550 so that we now have
fire()anddispatch()as two seperate methods.Furthermore its now possible to remove multiple elements at once when calling
SVG.off(). (Binding was already possible). It also adds the option argument toSVG.off()which is needed there.I made this PR to see which changes are required to make the proposal work. Its not that much overhead to manage HTMLNodes.
Comments are welcome!