Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Doc to SVG #932

Closed
Fuzzyma opened this issue Nov 17, 2018 · 5 comments
Closed

Rename Doc to SVG #932

Fuzzyma opened this issue Nov 17, 2018 · 5 comments
Milestone
3.0.0

Comments

@Fuzzyma
Copy link
Member

Fuzzyma commented Nov 17, 2018

Currently the Doc object is representing the <svg> tag. Since Nested got removed, Doc is used for both. It would make sense to go with the normal naming scheme of the libraray and aname the object Svg instead. As I know @saivan is a friend of this idea. So am I.

What do you think @wout @dotnetCarpenter ?
@Fuzzyma Fuzzyma added this to the 3.0.0 milestone Nov 17, 2018
@wout
Copy link
Member

wout commented Nov 17, 2018

Good for me. It's more in line with the rest of the class names and it's the ideal time to re-evaluate such inconsistencies.

Fuzzyma added a commit that referenced this issue Nov 19, 2018
@Fuzzyma
renamed Doc to Svg according to (#932)
9943813
@Fuzzyma
Copy link
Member Author

Fuzzyma commented Nov 19, 2018

Just pushed the change.

However, one more thought: does it make sense to rename the doc() method to root()?
I dont have a strong opinion to either of these. So if noone cares we just let it as it is

@Fuzzyma Fuzzyma mentioned this issue Nov 19, 2018
Closed
@wout
Copy link
Member

wout commented Nov 19, 2018

I think it makes perfect sense!

@Fuzzyma
Copy link
Member Author

Fuzzyma commented Nov 19, 2018

Well in that case I will go ahead and change that, too

Fuzzyma added a commit that referenced this issue Nov 19, 2018
@Fuzzyma
rename doc() to root() and toDoc() to toRoot() as dicussed in (…
2b37d7b 
…#932)
@saivan
Copy link
Member

saivan commented Nov 20, 2018

Yes pleaseeeeeeeeeeeeeee 😀

@Fuzzyma Fuzzyma closed this as completed Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
3 participants
@wout @Fuzzyma @saivan