Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<svg> element appended to end of body receives tab focus on IE11 #908

Closed
kalexmills opened this issue Sep 28, 2018 · 1 comment
Closed

<svg> element appended to end of body receives tab focus on IE11 #908

kalexmills opened this issue Sep 28, 2018 · 1 comment

Comments

@kalexmills
Copy link

Bug report

There is a well-known IE11 issue regarding SVG elements receiving tab focus. Svg.js currently adds an extra svg tag to the bottom of the body, which receives this focus.

The fix is to add focusable=false to the <svg> tag with ID SvgJsSvg1001. Right now, we are having to wait for the library to inject this DOM and hack this attribute in ourselves. It would be great if users didn't have to do that.

Fiddle

This behavior should be seen in the minimal example.

Explanation

  • What is the behaviour you expect?

On IE11, when tabbing away from the last focusable element on the page, the browser should receive the next tab.

  • What is happening instead?

An extra tab is needed, because the added <svg> tag is receiving the focus inappropriately.

  • What error message are you getting?

None.
@saivan
Copy link
Member

saivan commented Oct 3, 2018 •
edited
Loading

Ah I see! Thats totally fair!
Feel free to make a pr for this one, I don't have a working IE browser to test this on (I don't use windows),
but I think we can merge this one without too many problems.

Fuzzyma added a commit that referenced this issue Nov 13, 2018
@Fuzzyma
Round up everything for the last 2.x release
5a72b48 
### Fixed
- fixed calling `parent()` on `documentFragment`s children (#927)
- parser is not focusable anymore (#908)
- `SVG.Element.click(null)` correctly unbinds the event (#878)
- fix memory leak (#905)

### Added
- `SVG.Set` now accepts another Set as input (#893)
- `on()/off()` accepts multiple event names as input (backport from 3.0)
@Fuzzyma Fuzzyma closed this as completed Nov 13, 2018
@lenzls lenzls mentioned this issue Jul 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Fuzzyma @saivan @kalexmills