Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested svgs have unneeded namespace attributes #1086

Closed
Fuzzyma opened this issue Feb 24, 2020 · 0 comments
Closed

Nested svgs have unneeded namespace attributes #1086

Fuzzyma opened this issue Feb 24, 2020 · 0 comments

Comments

@Fuzzyma
Copy link
Member

Fuzzyma commented Feb 24, 2020

When creating a nested svg with nested() the resulting svg has namespaceattributes which are not needed there.
Fuzzyma added a commit that referenced this issue Apr 3, 2020
@Fuzzyma
- fixed put() which correctly creates an svgjs object from the pas…
7547a6a 
…sed element now before returning

 - fixed `parent()` which correctly returns null if direct parent is the document or a document-fragment
 - fixed `add()` which correctly removes namespaces of non-root svg elements now when added to another svg element (#1086)
 - fixed `isRoot()` which correctly returns false, if the element is in a document-fragment
@Fuzzyma Fuzzyma closed this as completed Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Fuzzyma