Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial implementation of julia module #392

Merged
merged 10 commits into from
Sep 13, 2022

Conversation

FedericoStra
Copy link
Contributor

@FedericoStra FedericoStra commented Sep 8, 2022

This is an initial implementation of the module julia. It simulates the process of updating all the packages in a project.

There are still some features missing:

  • downloading artifacts
  • building artifacts
  • possible old manifest format
  • garbage collection
  • dynamic package precompilation

If there is some interest, I can work on adding them.

Here is a preview of what it looks like (this is an old version without artifacts and precompilation progress bar):

Preview

Updated asciinema recording (others are available on my account):

@FedericoStra
Copy link
Contributor Author

FedericoStra commented Sep 9, 2022

Massive refactor on the way.

Copy link
Owner

@svenstaro svenstaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is some very cool output! I think this would make a good module.

src/modules/julia.rs Outdated Show resolved Hide resolved
src/modules/julia.rs Outdated Show resolved Hide resolved
src/modules/julia.rs Outdated Show resolved Hide resolved
src/modules/julia.rs Outdated Show resolved Hide resolved
src/modules/julia.rs Outdated Show resolved Hide resolved
@svenstaro
Copy link
Owner

Would you like to implement the rest of your checklist in this PR? I'd be good to merge this as is. We need to fix the CI, though. I'm working on a fix.

@svenstaro
Copy link
Owner

Ok, please rebase. Should be good now.

@FedericoStra
Copy link
Contributor Author

Would you like to implement the rest of your checklist in this PR? I'd be good to merge this as is. We need to fix the CI, though. I'm working on a fix.

I think I'll have to leave the dynamic precompilation for another time. Maybe I can open an issue to keep track that it's missing so anyone can see it and possibly implement it.

@svenstaro
Copy link
Owner

Good work, clean. Great output, too!

@svenstaro svenstaro merged commit 7c0f55e into svenstaro:master Sep 13, 2022
@svenstaro
Copy link
Owner

svenstaro commented Sep 13, 2022

Hey, I noticed that the julia logo doesn't look great in the web version:
image
but I already merged. :/

Could you look into that?

You can check the problem live here: https://svenstaro.github.io/genact/?module=julia

Or just compile it yourself to debug it.

@FedericoStra
Copy link
Contributor Author

Could you look into that?

You can check the problem live here: https://svenstaro.github.io/genact/?module=julia

Or just compile it yourself to debug it.

I don't know how to build and run the web version, but I think I know the source of the bug: the Julia banner is hard coded as a multiline string, hence the newlines are just \n and not \r\n. I'll address that.

@svenstaro
Copy link
Owner

Try:

make build-web
miniserve --route-prefix=genact dist
firefox localhost:8080/genact/index.html

@FedericoStra
Copy link
Contributor Author

FedericoStra commented Sep 13, 2022

make build-web

I don't have trunk installed nor do I know where to get it.

Edit: oh I see, it's a Rust crate! I thought it were some node.js shenanigan...

@FedericoStra
Copy link
Contributor Author

FedericoStra commented Sep 13, 2022

This should fix it: #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants