Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs($state): Add example on function re-binding for class methods #14610

Closed
wants to merge 1 commit into from

Conversation

webJose
Copy link
Contributor

@webJose webJose commented Dec 8, 2024

No issue to associate this with. Just adding the possibility of using bind() with class methods.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Dec 8, 2024

⚠️ No Changeset found

Latest commit: 3e37dfa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14610-svelte.vercel.app/

this is an automated message

Copy link
Contributor

github-actions bot commented Dec 8, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14610

@Rich-Harris
Copy link
Member

Thank you. While this works, and is totally valid, it's actually not something we want to encourage. The reason is that while onclick={todo.reset} compiles to this...

button.__click = function (...$$args) {
  todo.reset?.apply(this, $$args);
};

...and onclick={() => todo.reset()} compiles to this...

// hoisted
var on_click = (_, todo) => todo.reset();

// in component
button.__click = [on_click, todo];

...onclick={todo.reset.bind(todo)} compiles to this:

var event_handler = $.derived(() => todo.reset.bind(todo));

button.__click = function (...$$args) {
  $.get(event_handler)?.apply(this, $$args);
};

In other words, in exchange for writing more code, we've caused the compiler to add a signal to the graph (which is unnecessary in this case, but the compiler can't know that) and generate bulkier output. Using bind made sense in the bad old days before arrow functions, but there isn't really much call for it nowadays.

@Rich-Harris Rich-Harris closed this Dec 9, 2024
@webJose webJose deleted the JP/state-derived-docs branch December 9, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants