-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Code of Conduct #332
Conversation
@jdorfman @XhmikosR I don't care about these errors. Can you remove them from the tests?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In case the diff is hard: here is where the text comes from. https://docs.google.com/document/d/1BxfHoV_zLSwZJbw1o-fF7MADfu0nLFi7-G8q3mc1Wqc/edit |
@RichardLitt https://github.com/sustainers/website/blob/main/.markdownlint.json That being said, I wouldn't disable |
@XhmikosR I don't think it's a good rule. Is there a way to get a hint about it, instead of a failing error? |
It definitely is a good rule. Heading levels should follow a hierarchical order: |
As I said, I disagree. I don't think it's a useful rule, because I don't use headers according to the specification, but how they are displayed on the page. I don't respect the authority of w3 or Deque University over my own aesthetic preferences. |
Right. Shouldn't be to hard to figure out how to ignore it then. |
Thanks. I can change the linter - my relevant question I'm not sure about is how can I make the tests not cause a failure in the build, but a warning? Alternatively, how can I change the test to fail on some of the issues, but only show a warning on others? I can look it up, but I think that you @XhmikosR and @jdorfman set this up, so I'm curious if you have thoughts on this first and know how faster. |
slug: code-of-conduct-faq | ||
--- | ||
|
||
# Code of Conduct FAQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Justin Dorfman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just read the content, not for grammatical or spelling but for the general gist of the content and how well it aligns to my understanding of the process and the conversations that we have had. On that basis LGTM
It should be also possible to do something like this (untested): ### h3 heading that looks like h4
{: .h4 } |
Signed-off-by: Justin Dorfman <[email protected]>
@XhmikosR these failed tests are not making sense. I fixed all of the errors and it still isn't passing. I'm probably doing something wrong, however I believe the test is flawed. |
@jdorfman fixed those |
Thanks, @XhmikosR. |
Thanks @XhmikosR I swear I pushed the |
This addresses issues noted by @piamancini.
I've had off-band messages from Pia and Gunner that this works for them. I'll merge this and institute it, and then schedule the next CoC conversation for three months from now. Thank you everyone for all of your hard work! |
Great work y'all |
LGTM - thanks |
I'd like approval from a lazy majority consensus of the organizing committee before merge.
Note that I've added a CoC FAQ and filled out as many of the questions I and @jwflory foresaw as I could.