Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[subgraph][spike] deploy protocol subgraphs to Goldsky #1918

Merged
merged 9 commits into from
Apr 8, 2024

Conversation

kasparkallas
Copy link
Contributor

@kasparkallas kasparkallas marked this pull request as draft March 27, 2024 13:03
Copy link

Changelog Reminder

Reminder to update the CHANGELOG.md for any of the modified packages in this PR.

  • CHANGELOG.md modified
  • Double check before merge

@kasparkallas kasparkallas changed the title [subgraph][spike][wip] deploy protocol subgraphs to Goldsky [subgraph][spike] deploy protocol subgraphs to Goldsky Apr 8, 2024
@kasparkallas kasparkallas marked this pull request as ready for review April 8, 2024 12:53
@kasparkallas kasparkallas requested a review from a team as a code owner April 8, 2024 12:53
Copy link
Contributor

@0xdavinchee 0xdavinchee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hellwolf
Copy link
Contributor

hellwolf commented Apr 8, 2024

build fails.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (2dbb63e) to head (4a93697).
Report is 3 commits behind head on dev.

❗ Current head 4a93697 differs from pull request most recent head b585cd1. Consider uploading reports for the commit b585cd1 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1918      +/-   ##
==========================================
+ Coverage   89.07%   96.97%   +7.90%     
==========================================
  Files         113       51      -62     
  Lines        5939     2846    -3093     
  Branches      216        0     -216     
==========================================
- Hits         5290     2760    -2530     
+ Misses        597       86     -511     
+ Partials       52        0      -52     
Flag Coverage Δ
ethereum-contracts 96.97% <ø> (ø)
sdk-core ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hellwolf
Copy link
Contributor

hellwolf commented Apr 8, 2024

@hellwolf hellwolf enabled auto-merge April 8, 2024 19:01
@hellwolf hellwolf added this pull request to the merge queue Apr 8, 2024
Merged via the queue into dev with commit ba68544 Apr 8, 2024
18 of 19 checks passed
@hellwolf hellwolf deleted the chore-deploy-subgraphs-to-goldsky branch April 8, 2024 22:54
Copy link

github-actions bot commented Apr 8, 2024

XKCD Comic Relif

Link: https://xkcd.com/1918
https://xkcd.com/1918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants