This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
feat: list endpoints #1625
Merged
feat: list endpoints #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmarshall
requested review from
tomkit,
asdfryan and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
asdfryan
reviewed
Sep 21, 2023
| @@ -31,7 +31,7 @@ export default function init(app: Router): void { | |||
| const snakecasedKeysLead = toSnakecasedKeysCrmLead(lead); | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| const { raw_data, ...rest } = snakecasedKeysLead; | |||
| return res.status(200).send(req.query.include_raw_data === 'true' ? snakecasedKeysLead : rest); | |||
| return res.status(200).send(req.query?.include_raw_data?.toString() === 'true' ? snakecasedKeysLead : rest); | |||
There was a problem hiding this comment.
refactor into util function? There's a bunch of places where we do this.
asdfryan
reviewed
Sep 21, 2023
asdfryan
reviewed
Sep 21, 2023
asdfryan
reviewed
Sep 21, 2023
lucasmarshall
force-pushed
the
lucas/list-endpoints
branch
from
8124775 to
20679d6
Compare
asdfryan
reviewed
Sep 21, 2023
asdfryan
reviewed
Sep 21, 2023
apps/api/routes/crm/v2/account.ts
Outdated
| @@ -35,7 +35,7 @@ export default function init(app: Router): void { | |||
| req: Request<ListAccountsPathParams, ListAccountsResponse, ListAccountsRequest, ListAccountsQueryParams>, | |||
| res: Response<ListAccountsResponse> | |||
| ) => { | |||
| if (req.query?.read_from_cache?.toString() !== 'true') { | |||
| if (req.query?.read_from_cache !== true) { | |||
There was a problem hiding this comment.
Nit: !req.query?.read_from_cache
asdfryan
reviewed
Sep 21, 2023
asdfryan
approved these changes
Sep 21, 2023
|
Looks like there's some build failures? |
lucasmarshall
force-pushed
the
lucas/list-endpoints
branch
from
e1ecb58 to
a049ef9
Compare
asdfryan
approved these changes
Sep 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Tested locally against hubspot and salesforce account and contact lists