This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
fix: only fetch all assocations for flagged applications #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmarshall
requested review from
tomkit,
asdfryan and
george-xing
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
tomkit
reviewed
Sep 20, 2023
lucasmarshall
force-pushed
the
lucas/associations-feature-flag
branch
from
da40e5e to
f71c088
Compare
tomkit
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Does this create an empty key in the interface we hand off to customers and did we do that prior to fetching associations?
I'm thinking about whether this might cause confusion to developers consuming the response. @asdfryan might know more
supaglue/packages/core/remotes/impl/hubspot/index.ts Lines 826 to 827 in f71c088 |
asdfryan
reviewed
Sep 20, 2023
asdfryan
reviewed
Sep 20, 2023
tomkit
reviewed
Sep 20, 2023
asdfryan
approved these changes
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.