Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced makefile with poetry scripts #287

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Replaced makefile with poetry scripts #287

merged 3 commits into from
Oct 21, 2022

Conversation

cadnce
Copy link
Contributor

@cadnce cadnce commented Oct 12, 2022

Replaced makefile with poetry scripts.

@J0 , @dreinon is this something like you had in mind? I'm not really a fan of how you end up with the poetry_scripts.py at the top level. But it seems like there isn't really a consensus on how you should do this - python-poetry/poetry#2496

LMK if you had envisaged it somewhat differently/had a better example.

Fixes #102

@J0 J0 added the hacktoberfest Hacktoberfest 2022 label Oct 12, 2022
@cadnce
Copy link
Contributor Author

cadnce commented Oct 12, 2022

Oops, fixed that up. Not sure how i missed that. Must have been when I swapped between using poe and the builtin scripts

Copy link
Contributor

@J0 J0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR!

@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Base: 82.26% // Head: 78.37% // Decreases project coverage by -3.89% ⚠️

Coverage data is based on head (77bf12a) compared to base (36b71f3).
Patch coverage: 12.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #287      +/-   ##
===========================================
- Coverage    82.26%   78.37%   -3.90%     
===========================================
  Files            8        9       +1     
  Lines          141      148       +7     
===========================================
  Hits           116      116              
- Misses          25       32       +7     
Impacted Files Coverage Δ
poetry_scripts.py 0.00% <0.00%> (ø)
supabase/__version__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@J0 J0 merged commit 8e98ee2 into supabase:develop Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace makefile for poetry scripts
2 participants