Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #54

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Update README.md #54

merged 4 commits into from
Jan 17, 2023

Conversation

paulbgtr
Copy link
Contributor

Fixed some grammar mistakes and the "latest" mistake in the first paragraph

@sunnamed434 sunnamed434 linked an issue Dec 19, 2022 that may be closed by this pull request
@sunnamed434
Copy link
Owner

Good job. Could you please change the pull request target into the dev (i.e dev - patch-1)

@sunnamed434
Copy link
Owner

Alright, you did it a bit wrong that made it in the main branch, but it's okay, I'll fix it later then.

Copy link
Owner

@sunnamed434 sunnamed434 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@paulbgtr
Copy link
Contributor Author

paulbgtr commented Dec 20, 2022

It's actually a bit interesting what I have done here because I somehow forgot to fix the "latest" mistake. However I just fixed it.
Excuse me also for merging into the wrong branch. What should I do next then?

Copy link
Owner

@sunnamed434 sunnamed434 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, reviewed

@sunnamed434
Copy link
Owner

It's actually a bit interesting what I have done here because I somehow forgot to fix the "latest" mistake. However I just fixed it. Excuse me also for merging into the wrong branch. What should I do next then?

Thanks for fixing it, I'll merge and fix the conflicts in the dev and main branches later.

@paulbgtr paulbgtr changed the base branch from main to dev January 14, 2023 10:05
@sunnamed434 sunnamed434 merged commit f5f3ab9 into sunnamed434:dev Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README mistake
2 participants