Make the lock_api dependency optional.
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `lock_api`, this crate only provides a small number of types such as `RawMutex` and `RawRwLock`, but if someone needs just those, it's reasonable to provide them without depending on `lock_api`. This also makes `RawMutex` and `RawRwLock` easier to use, because it's no longer necessary to import the `lock_api` traits with the `as _` trick.
Closed
|
On further reflection, I don't like how this meant that the |
notgull
approved these changes
Jun 12, 2024
Using a `pub use` instead of a `pub type` alias gives it better rustdoc documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
lock_api, this crate only provides a small number of types such asRawMutexandRawRwLock, but if someone needs just those, it's reasonable to provide them without depending onlock_api.This also makes
RawMutexandRawRwLockeasier to use, because it's no longer necessary to import thelock_apitraits with theas _trick.