New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sophora-server][sophora-cluster-common] change path of grpc ingresses #140

Merged

philmtd merged 2 commits into main from change-grpc-path-in-server-example-values

Dec 9, 2024

Member

philmtd commented Dec 9, 2024

Required due to an internal refactoring which affects the paths of the gRPC traffic.


          [sophora-server][sophora-cluster-common] change path of grpc ingresses

29d1297

philmtd assigned schwerlaut


          [sophora-server][sophora-cluster-common] add more documentation for d…

1b2567f

…istinction between srpc and grpc

schwerlaut approved these changes

View reviewed changes

Contributor

schwerlaut left a comment

Looks good to me.
I've been adding some more comments to give a bit of clarification on what srpc is supposed to be.

philmtd merged commit e67f23f into main

2 checks passed

philmtd deleted the change-grpc-path-in-server-example-values branch

December 9, 2024 15:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet